-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(app): clarify iOS setup instructions, especially around use_frameworks #6856
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few thoughts on this one - i think a couple of the suggested changes could be really helpful, but many of the suggestions here are not valid for react-native-firebase specific install docs I don't think
What do you think?
I reviewed the comments you gave me one by one. My PR is a modification to the extent that it once again clarifies where the code should go in, I can understand if you accept this PR or reject it. Anyway, thank you again for the detailed review. :) |
Would just like to add that I was recently tripped up by exactly this. I worked out that I needed to make those changes, but I would've saved a few hours had the docs read like this. 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies this went to sleep! I think it is small now but still quite a useful change, thank you!
Description
https://github.com/mikehardy/rnfbdemo/blob/main/make-demo.sh
by @mikehardymake-demo.sh
, I updated the documentation (iOS setup part ingetting started
)Related issues
#6853
Release Summary
Checklist
../blob/main/CONTRIBUTING.md
instead of../CONTRIBUTING.md
)Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter