From f01108fbf5cc87457c8b702d60640d4af74f949a Mon Sep 17 00:00:00 2001 From: Kieren Evans Date: Thu, 30 Mar 2023 16:59:23 +0300 Subject: [PATCH] The default tideways service name is now 'app' --- UPGRADE.md | 13 +++++++++++++ src/_base/harness/attributes/common.yml | 2 +- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/UPGRADE.md b/UPGRADE.md index 9b89025dd..2da1007cf 100644 --- a/UPGRADE.md +++ b/UPGRADE.md @@ -4,6 +4,8 @@ In addition to the README's [Harness Upgrade Instructions], please note these sp ## Upgrading from 1.4.x to 1.5.x +### Drupal Writable Directories + The drupal harness no longer sets /app/config, /app/docroot/modules and /app/docroot/profiles to be web-writable at runtime. This means that modules cannot be installed via the admin interface unless you are running in the development environment. @@ -22,6 +24,17 @@ attribute('app.web_writable_files'): - '/app/docroot/modules/MODULE_NAME/path/to/file.png ``` +### Tideways default application + +The default service name for new tideways applications has changed from "web" to "app". + +The php.ini configuration for tideways been adjusted to reflect this to avoid confusion with new applications. + +To use the old service name "web", set this attribute in your workspace.yml: +```yaml +attribute('php.ext-tideways.config.service'): web +``` + ## Upgrading from 1.4.0 to 1.4.1 An unintentional helm service key name `resources.cpu.requests` has dropped it's plurality to `resources.cpu.request` to match some existing implementations. diff --git a/src/_base/harness/attributes/common.yml b/src/_base/harness/attributes/common.yml index 839c8c409..160771aa9 100644 --- a/src/_base/harness/attributes/common.yml +++ b/src/_base/harness/attributes/common.yml @@ -275,7 +275,7 @@ attributes.default: connection: "tcp://tideways:9135" collect: tracing sample_rate: 25 - service: web + service: app ext-xdebug: version: "= (version_compare(@('php.version'), '8.0', '>=') ? '3' : '2')" enable: false