Add slider for VRAM cache in configure script #4133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
GreggHelt2,
Kyle0654,
StAlKeR7779,
blessedcoolant,
brandonrising,
damian0815,
ebr and
psychedelicious
as code owners
psychedelicious
approved these changes
Aug 5, 2023
blessedcoolant
approved these changes
Aug 5, 2023
ebr
approved these changes
Aug 9, 2023
Contributor
ebr
left a comment
ebr
left a comment
There was a problem hiding this comment.
Max VRAM slider works great. (I did hit an edge case where npyscreen crashed after resizing the window, but can't consistently reproduce it)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
On CUDA systems, this PR adds a new slider to the install-time configure script for adjusting the VRAM cache and suggests a good starting value based on the user's max VRAM (this is subject to verification).
On non-CUDA systems this slider is suppressed.
Please test on both CUDA and non-CUDA systems using:
To see and test the default values, move
invokeai.yamlout of the way before running.Note added 8 August 2023
This PR also fixes the configure and model install scripts so that if the window is too small to fit the user interface, the user will be prompted to interactively resize the window and/or change font size (with the option to give up). This will prevent
npyscreenfrom generating its horrible tracebacks.Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?