Refrain from writing deprecated legacy options to invokeai.yaml

[lstein]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update
• Community Node Submission

Have you discussed this change with the InvokeAI team?

• Yes
• No, because:

Have you updated all relevant documentation?

• Yes
• No

Description

When migrating the invokeai.init legacy configuration file to the new .yaml format, do not copy any deprecated fields. This PR also activates the Pydantic validate_assignment behavior which raises an exception when an instantiated config object is updated with invalid values.

Related Tickets & Documents

• Related Issue #
• Closes #

QA Instructions, Screenshots, Recordings

Added/updated tests?

• Yes
• No : please replace this line with details on why tests
  have not been included

[optional] Are there any post deployment tasks we need to perform?

[psychedelicious]

I'm approving this, assuming it resolves the issue, but I did raise some concerns as comments, which may be relevant.

[psychedelicious]

Ah, I missed your comments in the PR itself about validate_assignment, cool.

I'd still like to understand why this PR couldn't just add that as a safeguard, and then remove the restore field from the config model. If we aren't going to reference it, why do we need to maintain that value?

[lstein]

Ah, I missed your comments in the PR itself about validate_assignment, cool.

I'd still like to understand why this PR couldn't just add that as a safeguard, and then remove the restore field from the config model. If we aren't going to reference it, why do we need to maintain that value?

I will remove the deprecated fields and see if it causes any issues. As I recall, the presence of additional fields in invokeai.yaml were causing exceptions, and this was without setting Extra.ignore. But the code has changed a lot since then.

[psychedelicious]

I've marked the conversations resolved so we can get this important fix in, but I think there's some room to improve how we handle InvokeAIAppConfig to better leverage the data integrity confidence afforded by Pydantic.

[lstein]

I've removed the deprecated options from config, tested both install and web server, and all seems well.