Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FieldNameTag config #64

Closed
wants to merge 1 commit into from

Conversation

mathewTH
Copy link
Contributor

@mathewTH mathewTH commented Jan 5, 2023

Allows field names to be based on a different tag. Json is still the default tag so this is not a breaking change. #28 (reply in thread)

Allows field names to be based on a different tag.
Json is still the default tag so this is not a breaking change.
invopop#28 (reply in thread)
Copy link

@josearomeroj josearomeroj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samlown samlown added the needs tests Not enough tests for this to be accepted label Apr 4, 2023
@samlown
Copy link
Contributor

samlown commented Apr 4, 2023

Thanks! Seems good from the outset, but we'd need some tests to validate it works as expected.

@balki
Copy link
Contributor

balki commented Apr 18, 2023

Thanks! Seems good from the outset, but we'd need some tests to validate it works as expected.

Added test here. Please take a look.

@samlown
Copy link
Contributor

samlown commented Jun 12, 2023

Added test here. Please take a look.

Awesome. I'll close this one.

@samlown samlown closed this Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests Not enough tests for this to be accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants