Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clone/install of independ to workflow #909

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

xexyl
Copy link
Contributor

@xexyl xexyl commented Jul 12, 2024

This is needed for the make slow_release. It is not an error if it is not installed but since it's used it might be good to have it work.

This is needed for the make slow_release. It is not an error if it is
not installed but since it's used it might be good to have it work.
@xexyl
Copy link
Contributor Author

xexyl commented Jul 12, 2024

Let's see how this goes.

I'll be going afk for a bit soon ... momentarily I think actually. But I might be back for a bit after that.

Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We intend to fix this:

...
   - name: clone picky
      run: git clone https://github.com/xexyl/picky
...
    - name: install picky
      run: cd picky && make && sudo cp -p picky /usr/local/bin
    - name: make

As our picky repo can install.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 12, 2024

We intend to fix this:

...
   - name: clone picky
      run: git clone https://github.com/xexyl/picky
...
    - name: install picky
      run: cd picky && make && sudo cp -p picky /usr/local/bin
    - name: make

As our picky repo can install.

Hmm ... yes I thought I did do that. That has to be my fork that I used to fix the code. I thought I already did that. Well I have had a hard time keeping track of things lately so it's not surprising I guess.

I can do that if you like though? Saves you the time.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 12, 2024

Actually wait .. don't change that GitHub URL. I think your copy is the fork. I remember distinctly setting it up for here and if you look at the Makefile you'll see the URL refers to my repo.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 12, 2024

Yes your copy is the fork. If you look at the README.md you'll see that's my writing style and I used the date in the form of day first.

@xexyl
Copy link
Contributor Author

xexyl commented Jul 12, 2024

You'll also see:

For most environments except DOS/Windows the simple Makefile provided will create the executable.

To clone and compile you can do e.g.:

git clone https://github.com/xexyl/picky
cd picky
make

which suggests that it is indeed a fork :-)

Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved as modified by commit bf469e1bef4023cb0f4419ee74c0874a873abade

@lcn2 lcn2 merged commit 1ca56bc into ioccc-src:master Jul 12, 2024
3 checks passed
@lcn2
Copy link
Contributor

lcn2 commented Jul 12, 2024

Sorry (tm Canada 🇨🇦), we were working in the on the PR, and didn't see the above comments until just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants