Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debian packaging #164

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pehrsoderman
Copy link

Adds a build target to build the debian package with resonable flags, and also adds a test building to the travis ci.

@soufrabi
Copy link

soufrabi commented Jul 3, 2024

This would be really helpful. I believe instructions to build the debian package should also be used in the documentation.

@gollux
Copy link
Member

gollux commented Jul 4, 2024

I plan to document Debian packaging before the next release. The current implementation is an experiment I haven't made up my mind yet. Adding a Makefile target to build the package makes sense.

I completely forgot that we have a configuration for Travis CI :) I do not use it and I rather think I should remove it and maybe replace by GitHub Actions.

@pehrsoderman
Copy link
Author

The current implementation is an experiment I haven't made up my mind yet.

I just retired our custom packaging of isolate we used internally in Kattis, so I would selfishly appreciate if the debian packaging of isolate remains. Otherwise I have to revert stuff in our infrastructure and resurrect our custom kattis-isolate package :(

I do not use it and I rather think I should remove it and maybe replace by GitHub Actions.

GitHub Actions are very nice. Highly recommended, after struggling with Travis and Drone.

@gollux
Copy link
Member

gollux commented Jul 4, 2024

No worries, packaging is here to stay. What I was unsure about were mostly details.

@soufrabi
Copy link

I would like to write the github action files for the debian packaging. Isolate does not work well in unprivileged docker containers so testing is not possible. However, build process could be automated.

@pehrsoderman
Copy link
Author

Isolate does not work well in unprivileged docker containers so testing is not possible.

If you use a self-hosted runner you can set it up to run Isolate. We do this in our CI. Obviously, you would have to restrict who can run the actions for security reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants