Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: better cleanup #13

Open
ionelmc opened this issue Jan 9, 2015 · 6 comments
Open

Idea: better cleanup #13

ionelmc opened this issue Jan 9, 2015 · 6 comments

Comments

@ionelmc
Copy link
Owner

ionelmc commented Jan 9, 2015

Automatically release lock if it gets garbage collected. Eg:

@Suor
Copy link

Suor commented Feb 26, 2015

Please don't do that. Explicit handling is more reliable.

@ionelmc
Copy link
Owner Author

ionelmc commented Feb 27, 2015

Good programming is more reliable yes 😁 but maybe at least emit a warning when a held lock is getting __del__eted.

@ionelmc
Copy link
Owner Author

ionelmc commented Feb 27, 2015

That would be exactly like how Python 3 emits warnings when you forgot to close the file.

@AndreiPashkin
Copy link
Contributor

In cases when you have lock shared between processes, you want it to live even after some process is gone.

@AndreiPashkin
Copy link
Contributor

Auto-renewal thread should probably be cleaned up on garbage collection

@ionelmc
Copy link
Owner Author

ionelmc commented Feb 20, 2016

(the autorenewal cleanup implemented in #33)

brainix added a commit to brainix/pottery that referenced this issue Nov 22, 2020
brainix added a commit to brainix/pottery that referenced this issue Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants