Screen Reader #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just wanted to make a note: this plugin is susceptible to memory leaks when used in embedded. I think we need to add a call to |
|
Something to be cognizant of when migrating these plugins. I added a Plugin Transfer Checklist to ionic-team/capacitor#3227. |
carlpoole
force-pushed
the
screen-reader
branch
from
ac6c12a
to
aa3804f
Compare
jcesarmobile
requested changes
Aug 6, 2020
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
|
I think we should start with 0.0.1 while Capacitor 3 is in alpha. We can switch them all to 1.0.0 when Capacitor 3 is released. |
jcesarmobile
approved these changes
Aug 18, 2020
ikeith
approved these changes
Aug 18, 2020
carlpoole
requested changes
Aug 18, 2020
screen-reader/android/src/main/java/com/capacitorjs/plugins/screenreader/ScreenReader.java
Outdated
Show resolved
Hide resolved
...en-reader/android/src/main/java/com/capacitorjs/plugins/screenreader/ScreenReaderPlugin.java
Outdated
Show resolved
Hide resolved
carlpoole
approved these changes
Aug 19, 2020
jcesarmobile
added a commit
that referenced
this pull request
May 13, 2021
kpatfln
pushed a commit
to kpatfln/capacitor-plugins
that referenced
this pull request
Apr 27, 2022
Add Progress Bar to Splash Screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
see ionic-team/capacitor#3364 and ionic-team/capacitor-testapp#2