Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reword the Periodic Maintenance section #2071

Merged
merged 1 commit into from
Nov 12, 2019

Conversation

jcesarmobile
Copy link
Member

The Periodic Maintenance section looks confusing to me, it sounds like the project gets borked or something, and also says update command updates dependencies, which it doesn't.
So renaming the section and rewording a little to not mislead.

Copy link
Contributor

@dotNetkow dotNetkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through this, I think I was try to specify:

  • How do you update Capacitor plugins?
  • How do you update the native iOS and Android project templates?

Re-reading, I think section #5 covers this, yes? If so, you might delete section 4. Or, keep your changes here. either one looks good.

@jcesarmobile
Copy link
Member Author

No, section 5 explains how to update Capacitor itself (the capacitor packages), section 4 tells the users they need to run update command after installing a Cordova or Capacitor plugin

@jcesarmobile jcesarmobile merged commit 7009d37 into ionic-team:master Nov 12, 2019
@jcesarmobile jcesarmobile deleted the reword branch November 12, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants