-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): implement getDeliveredNotifications and removeDeliveredNotifications #2266
fix(android): implement getDeliveredNotifications and removeDeliveredNotifications #2266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This is 23 days old. Can we please merge that? |
How I'm supposed to use the removeDeliveredNotifications? If I first use getDeliveredNotifications and pass the result to removeDeliveredNotifications, all the ids are 0, so doesn't remove the notifications. For local notifications it works since we set the id, but it's confusing since the PR is about Push notifications |
@jcesarmobile In my use-case I have a subclass of |
yeah, but on a regular Capacitor app this will happen, and I'm concerned about users complaining about it |
I think that having these methods implemented is better than not. I agree that users may encounter the issue you mentioned, but we can make a new issue to find out why the IDs of the notifications are 0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, looks good
This PR implements the
PushNotifications
plugingetDeliveredNotifications
andremoveDeliveredNotifications
methods.The fields available on the objects returned by
getDeliveredNotifications
are a subset of those available on iOS, but otherwise the behaviour should be the same.