-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Closed
Labels
package: vue@ionic/vue package@ionic/vue packagetype: buga confirmed bug reporta confirmed bug report
Milestone
Description
Bug Report
Ionic version:
[ ] 4.x
[x] 5.x
Current behavior:
Given a route of /page/:id, going from /page/1 to page/2 does not result in a nav transition. The new page content simply appears.
Expected behavior:
I would expect that there is a nav transition.
Related code:
We need to implement the following logic in Ionic Vue, similar to how Ionic React does it:
ionic-framework/packages/react-router/src/ReactRouter/StackManager.tsx
Lines 166 to 175 in 91aaaab
| // If a page is transitioning to another version of itself | |
| // we clone it so we can have an animation to show | |
| const match = matchComponent(leavingViewItem.reactElement, routeInfo.pathname, true); | |
| if (match) { | |
| const newLeavingElement = clonePageElement(leavingViewItem.ionPageElement.outerHTML); | |
| if (newLeavingElement) { | |
| this.routerOutletElement.appendChild(newLeavingElement); | |
| await runCommit(enteringViewItem.ionPageElement, newLeavingElement); | |
| this.routerOutletElement.removeChild(newLeavingElement); |
insert short code snippets here
Other information:
See: #22658 (comment) and #22658 (comment)
GC-Mark, sheamusburns, mhartington and wsamoht
Metadata
Metadata
Assignees
Labels
package: vue@ionic/vue package@ionic/vue packagetype: buga confirmed bug reporta confirmed bug report