Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Navigation triggered outside Angular zone, did you forget to call 'ngZone.run()'? after update to 5.8.2 and higher #24051

Closed
4 of 6 tasks
mvandenbrink opened this issue Oct 9, 2021 · 4 comments · Fixed by #24054
Labels
package: angular @ionic/angular package type: bug a confirmed bug report
Milestone

Comments

@mvandenbrink
Copy link

mvandenbrink commented Oct 9, 2021

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x

Current Behavior

After the update to ionic 5.8.1 I get a warning in the console log. The new page is loaded, but the NGRX selectRouter isn't triggered anymore to load the new data with a subscription. In the list page the navigateByUrl() is used.

Expected Behavior

No warning from ngZone.run() in the console log and emitting the NGRX selectRouter to load the data with selectors.

Steps to Reproduce

Update "@ionic/angular" package from "5.8.1" to "5.8.2"

Code Reproduction URL

see https://github.com/mvandenbrink/ionic-issue-24051

Ionic Info

$ ionic info

Ionic:

Ionic CLI : 6.17.1 (C:\Users****\AppData\Roaming\npm\node_modules@ionic\cli)
Ionic Framework : @ionic/angular 5.8.2
@angular-devkit/build-angular : 12.2.9
@angular-devkit/schematics : 12.2.9
@angular/cli : 12.2.9
@ionic/angular-toolkit : 4.0.0

Cordova:

Cordova CLI : not installed
Cordova Platforms : not available
Cordova Plugins : not available

Utility:

cordova-res : not installed globally
native-run : not installed globally

System:

NodeJS : v14.17.1 (C:\Program Files\nodejs\node.exe)
npm : 6.14.13
OS : Windows 10

Additional Information

I saw in the release notes a bug fix for angular: use initialize function when setting up ionic angular to avoid config errors (#24004) (f112ad4), closes #22853. It seems that this broke something. In ionic/angular 5.8.3 this issue still occurs.

I could reproduce my issue with the ActionSheetController, see code reproduction URL. If the ionic/angular is downgraded to 5.8.1 everything is working fine.

@ionitron-bot ionitron-bot bot added the triage label Oct 9, 2021
@liamdebeasi liamdebeasi added package: angular @ionic/angular package type: bug a confirmed bug report labels Oct 11, 2021
@liamdebeasi liamdebeasi added this to the 5.8.4 milestone Oct 11, 2021
@liamdebeasi
Copy link
Contributor

Thanks for the issue. This has been resolved via #24054, and a fix will be available in an upcoming release of Ionic Framework.

@liamdebeasi
Copy link
Contributor

This is fixed in Ionic Angular v5.8.4. Thanks for the report!

npm install @ionic/angular@latest

@mvandenbrink
Copy link
Author

Thanks, I can confirm that I have no issues anymore.

@ionitron-bot
Copy link

ionitron-bot bot commented Nov 10, 2021

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Nov 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: angular @ionic/angular package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants