Skip to content

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Jun 9, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Builds started sporadically failing due to peer dependency issues: https://github.com/ionic-team/ionic-framework/runs/6816022047?check_suite_focus=true

@stencil/sass was fixed to v1.3.2 which expects v1.x of @stencil/core

There are also other errors that recently started to appear: https://github.com/ionic-team/ionic-framework/runs/6816384171?check_suite_focus=true

What is the new behavior?

  • Bump @stencil/sass to ^1.5.2 which expects @stencil/core >=1.0.2
  • This also migrates our division usage within framework to avoid many deprecation warnings.
  • Regenerates all package-lock files

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi marked this pull request as ready for review June 9, 2022 15:51
@liamdebeasi liamdebeasi requested a review from a team June 9, 2022 15:51
@github-actions github-actions bot added the package: core @ionic/core package label Jun 9, 2022
@github-actions github-actions bot added package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package labels Jun 9, 2022
@liamdebeasi liamdebeasi changed the title chore(): update @stencil/sass chore(): update @stencil/sass, regenerate package-locks Jun 9, 2022
@liamdebeasi liamdebeasi merged commit efe9e92 into main Jun 9, 2022
@liamdebeasi liamdebeasi deleted the bump-stencil-sass branch June 9, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants