Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browserDevtools: true doesn't make Chromium headful #2537

Closed
simonhaenisch opened this issue Jun 27, 2020 · 0 comments · Fixed by #4403
Closed

browserDevtools: true doesn't make Chromium headful #2537

simonhaenisch opened this issue Jun 27, 2020 · 0 comments · Fixed by #4403
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil

Comments

@simonhaenisch
Copy link
Contributor

simonhaenisch commented Jun 27, 2020

Stencil version:

 @stencil/core@1.15.0

I'm submitting a:
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/

Current behavior:

Setting testing.browserDevtools = true doesn't run Chromium in headful mode.

Expected behavior:

It does what the doc comment says:

Whether to auto-open a DevTools panel for each tab. If this option is true, the headless option will be set false

Other information:

I think

if (config.flags.devtools) {
config.testing.browserDevtools = true;
config.testing.browserHeadless = false;
should be moved into src/compiler/config/validate-testing.ts.

--

BTW I usually don't want to run e2e tests in headful mode but sometimes it helps to see what's going on, so having a --headful or --devtools flag would be quite convenient.

@simonhaenisch simonhaenisch added triage and removed bug labels Jul 27, 2020
@rwaskiewicz rwaskiewicz added the Bug: Validated This PR or Issue is verified to be a bug within Stencil label May 8, 2023
@ionitron-bot ionitron-bot bot removed the triage label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants