feat(mock-doc): dispatch blur and focus events #3449
Conversation
src/mock-doc/event.ts
Outdated
| export class MockFocusEvent extends MockUIEvent { | ||
| relatedTarget: EventTarget | null = null; | ||
|
|
||
| constructor(type: string, focusEventInitDic?: FocusEventInit) { |
There was a problem hiding this comment.
probably not crucial, but could we type type here as "blur" | "focus" ?
There was a problem hiding this comment.
Great catch thank you!
There was a problem hiding this comment.
I think just waiting on this change, and then it looks good!
There was a problem hiding this comment.
So sorry I missed that one! Just committed
src/mock-doc/test/event.spec.ts
Outdated
| }).toThrow(); | ||
| }); | ||
|
|
||
| it('FocusEvent(type)', () => { |
There was a problem hiding this comment.
just for completion's sake, what would you think about parameterizing this test across "blur", "focus"? something like this perhaps:
| it('FocusEvent(type)', () => { | |
| it.each(["blur", "focus"])('creates a %s-type MockFocusEvent', (focusType) => { |
| const eventInitDict = { | ||
| bubbles: true, | ||
| composed: true, | ||
| relatedTarget: null as EventTarget | null, |
There was a problem hiding this comment.
might be good to have a test where we pass a legit value through for this field, what do you think?
There was a problem hiding this comment.
I'm not sure what you mean by legit value?
There was a problem hiding this comment.
sorry should have been more explicit! just something that matches the EventTarget interface — not a super essential test though!
There was a problem hiding this comment.
I checked into this and it doesn't look like any of the Mock elements (MockInputElement, etc) inherit from EventTarget currently.
There was a problem hiding this comment.
ok no worries, let's leave it as-is then
Co-authored-by: Alice <alice.octavia.pote@gmail.com>
src/mock-doc/event.ts
Outdated
| export class MockFocusEvent extends MockUIEvent { | ||
| relatedTarget: EventTarget | null = null; | ||
|
|
||
| constructor(type: string, focusEventInitDic?: FocusEventInit) { |
There was a problem hiding this comment.
I think just waiting on this change, and then it looks good!
|
Going to merge this as an admin - "Tech Debt Burndown / Download error files and report (pull_request)" is failing (we'll fix this next sprint) for external contributors, but the report itself is being generated/reporting no new unused exports/strict null check violations |
rwaskiewicz
added
the
Resolution: Refine
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm test) were run locally and passednpm run test.karma.prod) were run locally and passednpm run prettier) was run locally and passedPull request type
For mock-doc,
blur()andfocus()methods will now dispatch an event. CreatedMockFocusEventwhich extends a newMockUIEvent, which extends the existingMockEvent.Please check the type of change your PR introduces:
What is the current behavior?
The blur and focus methods are empty.
What is the new behavior?
The methods now dispatch an event (similar to how
click()works) via theMockFocusEventclass with atypeproperty of'blur'or'focus'Does this introduce a breaking change?
Testing
Added tests for verify new
MockFocusEventinstantiationOther information