test(wdio): add a browser matrix for our wdio tests

[alicewriteswrongs]

This refactors a bit how we control what browsers are used in our webdriverio tests. Instead of it being chrome or all browsers, where all browsers are activated by setting the CI environment variable, this adds a check for a BROWSER environment variable. How this works is that the webdriverio configuration file reads the environmen variable and if it's one of FIREFOX, CHROME, or EDGE it will set the tests to use that browser. If it's not set (or set to an unrecognized value) we'll default to using chrome (as we do now), and if it's set to ALL it will run all of the browsers.

This also makes it easier for us to separate the test runs in separate browsers into separate jobs, so a failure only on Edge will show up more easily (and we'll get some more parallelism).

What is the current behavior?

You need to edit a file if you want to run tests in e.g. just Edge locally.

Documentation

Does this introduce a breaking change?

• Yes
• No

Testing

Other information

[github-actions]

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1137 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files

Path	Error Count
src/dev-server/index.ts	37
src/dev-server/server-process.ts	32
src/compiler/prerender/prerender-main.ts	22
src/runtime/client-hydrate.ts	20
src/testing/puppeteer/puppeteer-element.ts	20
src/screenshot/connector-base.ts	19
src/runtime/vdom/vdom-render.ts	17
src/dev-server/request-handler.ts	15
src/compiler/prerender/prerender-optimize.ts	14
src/compiler/sys/stencil-sys.ts	14
src/sys/node/node-sys.ts	14
src/compiler/prerender/prerender-queue.ts	13
src/compiler/sys/in-memory-fs.ts	13
src/runtime/connected-callback.ts	13
src/runtime/set-value.ts	13
src/compiler/output-targets/output-www.ts	12
src/compiler/transformers/test/parse-vdom.spec.ts	12
src/compiler/transformers/transform-utils.ts	12
src/compiler/transpile/transpile-module.ts	12
src/mock-doc/test/attribute.spec.ts	12

Our most common errors

Typescript Error Code	Count
TS2322	361
TS2345	344
TS18048	204
TS18047	82
TS2722	37
TS2532	24
TS2531	21
TS2454	14
TS2790	11
TS2352	9
TS2769	8
TS2538	8
TS2416	7
TS2493	3
TS18046	2
TS2684	1
TS2430	1

Unused exports report

There are 14 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports

File	Line	Identifier
src/runtime/bootstrap-lazy.ts	21	setNonce
src/screenshot/screenshot-fs.ts	18	readScreenshotData
src/testing/testing-utils.ts	198	withSilentWarn
src/utils/index.ts	145	CUSTOM
src/utils/index.ts	269	normalize
src/utils/index.ts	7	escapeRegExpSpecialCharacters
src/compiler/app-core/app-data.ts	25	BUILD
src/compiler/app-core/app-data.ts	115	Env
src/compiler/app-core/app-data.ts	117	NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts	123	updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts	61	satisfies
src/compiler/types/validate-primary-package-output-target.ts	61	Record
src/testing/puppeteer/puppeteer-declarations.ts	485	WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts	7	writeFetchSuccessSync

[github-actions]

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/8665404954/artifacts/1409429892

If your browser saves files to ~/Downloads you can install it like so:

unzip -d ~/Downloads ~/Downloads/stencil-core-4.15.0-dev.1712940926.61fff7b.tgz.zip && npm install ~/Downloads/stencil-core-4.15.0-dev.1712940926.61fff7b.tgz

[rwaskiewicz]

LGTM 👍 I'll defer to @christian-bromann in the event he thinks there's another way we could be doing this, but in general I'm in favor of this change.

We'll have to rename the checks when this is ready to merge, LMK when it's time and we'll do the dance of disabling the current one, merging this, and updating the names of the checks in GH's settings

[christian-bromann]

LGTM 👍