-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): prevent find
from throwing error when query has no match
#5641
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
test/end-to-end/src/non-existent-element/empty-cmp-shadow.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { Component, h, Host } from '@stencil/core'; | ||
|
||
@Component({ | ||
tag: 'empty-cmp-shadow', | ||
shadow: true, | ||
}) | ||
export class EmptyComponentShadow { | ||
render() { | ||
return <Host>I have no children!</Host>; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { Component, h, Host } from '@stencil/core'; | ||
|
||
@Component({ | ||
tag: 'empty-cmp', | ||
shadow: false, | ||
scoped: false, | ||
}) | ||
export class EmptyComponent { | ||
render() { | ||
return <Host>I have no children!</Host>; | ||
} | ||
} | ||
55 changes: 55 additions & 0 deletions
55
test/end-to-end/src/non-existent-element/non-existent-element.e2e.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
import { newE2EPage } from '@stencil/core/testing'; | ||
|
||
describe('Querying non-existent element(s)', () => { | ||
describe('Shadow DOM', () => { | ||
it('returns `null` if the element does not exist', async () => { | ||
// create a new puppeteer page | ||
const page = await newE2EPage({ | ||
html: ` | ||
<empty-cmp-shadow></empty-cmp-shadow> | ||
`, | ||
}); | ||
|
||
const elm = await page.find('empty-cmp-shadow >>> .non-existent'); | ||
expect(elm).toBeNull(); | ||
}); | ||
|
||
it('returns an empty array if no elements match the selector', async () => { | ||
// create a new puppeteer page | ||
const page = await newE2EPage({ | ||
html: ` | ||
<empty-cmp-shadow></empty-cmp-shadow> | ||
`, | ||
}); | ||
|
||
const elm = await page.findAll('empty-cmp-shadow >>> .non-existent'); | ||
expect(elm).toEqual([]); | ||
}); | ||
}); | ||
|
||
describe('Light DOM', () => { | ||
it('returns `null` if the element does not exist', async () => { | ||
// create a new puppeteer page | ||
const page = await newE2EPage({ | ||
html: ` | ||
<empty-cmp></empty-cmp> | ||
`, | ||
}); | ||
|
||
const elm = await page.find('empty-cmp >>> .non-existent'); | ||
expect(elm).toBeNull(); | ||
}); | ||
|
||
it('returns an empty array if no elements match the selector', async () => { | ||
// create a new puppeteer page | ||
const page = await newE2EPage({ | ||
html: ` | ||
<empty-cmp></empty-cmp> | ||
`, | ||
}); | ||
|
||
const elm = await page.findAll('empty-cmp >>> .non-existent'); | ||
expect(elm).toEqual([]); | ||
}); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# empty-cmp | ||
|
||
|
||
|
||
<!-- Auto Generated Below --> | ||
|
||
|
||
---------------------------------------------- | ||
|
||
*Built with [StencilJS](https://stenciljs.com/)* |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a similar component (and matching suite of tests) where it doesn't use
shadow
? I don't think it matters if it's totally non-encapsulated or usedscoped
- I just want to make sure that in the case there's not an actual shadow root, we handle that case as well.