This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Remove address scan in bootstrap #1861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
No longer scan milestones via the coo address. Instead walk up from the latest solid milestone and add the existing milestones to the solidifier queue to process
Replaces #1860. It has the exact same code + a little refactoring + removing a regression test.
Explanation for regression test removal
The test relied on scanning the db for milestones that we missed. Since we now assume the db has all milestones present, the test cannot work. This is a fine behavior change so we can safely remove the test.
An issue that can come up with this behavior change
If a node gets shutdown before receiving a milestone it may not register it. Then when it gets turned on it will not find it. This issue should be resolved by rebroadcasting the milestone
Type of change
How the change has been tested
Relied on tests done on #1860
Change checklist