Fix bugs uncovered with the increase in test coverage #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Potential `nil` pointer dereference when the outbound HTTP request experienced an error (request failed to complete). * Mistakenly expecting 403 to be the status code used when the API key provided is invalid. The first issue was that the `*http.Response` returned from `*http.Client.Do()` was being used in the error handling block for that function call to get the request's URL. This was updated to properly use `req.URL`. The second issue was simply catching the wrong HTTP status code on request processing. This updates the code, and tests, to use http.StatusUnauthorized for authentication failures. Signed-off-by: Tim Heckman <t@heckman.io>
theckman
added a commit
that referenced
this pull request
Dec 17, 2017
Fix bugs uncovered with the increase in test coverage Signed-off-by: Tim Heckman <t@heckman.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nilpointer dereference when the outbound HTTP request experiencedan error (request failed to complete).
is invalid.
The first issue was that the
*http.Responsereturned from*http.Client.Do()was being used in the error handling block for that function call to get the
request's URL. This was updated to properly use
req.URL.The second issue was simply catching the wrong HTTP status code on request
processing. This updates the code, and tests, to use http.StatusUnauthorized for
authentication failures.
Signed-off-by: Tim Heckman t@heckman.io