Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adapt deal filter format to CIDgravity / 修改 dealfilter 的实现, 以兼容 CIDgravity #329

Merged
merged 4 commits into from
May 17, 2023

Conversation

LinZexiao
Copy link
Collaborator

@LinZexiao LinZexiao commented May 17, 2023

关联的Issues (Related Issues)

close filecoin-project/venus#5834
ref filecoin-project/venus#5669

改动 (Proposed Changes)

  • 修改了 dealfiter 传出的数据结构
  • 当订单被拒绝时, 输出日志

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2023

Codecov Report

Merging #329 (daaee6c) into master (ddcfbc2) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
+ Coverage   22.11%   22.13%   +0.02%     
==========================================
  Files         181      181              
  Lines       21456    21464       +8     
==========================================
+ Hits         4744     4752       +8     
- Misses      15938    15940       +2     
+ Partials      774      772       -2     
Flag Coverage Δ
unittests 22.13% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dealfilter/cli.go 0.00% <0.00%> (ø)
storageprovider/deal_handler.go 3.73% <0.00%> (-0.02%) ⬇️

... and 2 files with indirect coverage changes

@LinZexiao LinZexiao requested a review from simlecode May 17, 2023 05:50
Copy link
Collaborator

@simlecode simlecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simlecode simlecode merged commit 8cb7c87 into master May 17, 2023
@simlecode simlecode deleted the fix/tanlang/adapt-deal-filter-output-to-CIDgravity branch May 17, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[venus-market]订单过滤器缺少错误信息日志
3 participants