Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh accounts when connect to gateway #158

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

simlecode
Copy link
Collaborator

@simlecode simlecode commented Nov 15, 2023

关联的Issues (Related Issues)

close

改动 (Proposed Changes)

  1. wallet 新加另一个 account
  2. gateway 重启后会发现第 1 步中 wallet 新加的 account 没有注册到 gateway

附注 (Additional Info)

自查清单 (Checklist)

在你认为本 PR 满足被审阅的标准之前,需要确保 / Before you mark the PR ready for review, please make sure that:

  • 符合Venus项目管理规范中关于PR的相关标准 / The PR follows the PR standards set out in the Venus project management guidelines
  • 具有清晰明确的commit message / All commits have a clear commit message.
  • 包含相关的的测试用例或者不需要新增测试用例 / This PR has tests for new functionality or change in behaviour or not need to add new tests.
  • 包含相关的的指南以及文档或者不需要新增文档 / This PR has updated usage guidelines and documentation or not need
  • 通过必要的检查项 / All checks are green

@simlecode simlecode self-assigned this Nov 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #158 (4186c59) into master (1051ee5) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
- Coverage   58.14%   58.12%   -0.03%     
==========================================
  Files          33       33              
  Lines        2406     2407       +1     
==========================================
  Hits         1399     1399              
  Misses        937      937              
- Partials       70       71       +1     
Flag Coverage Δ
unittests 58.12% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
walletevent/wallet_client.go 67.64% <100.00%> (+0.23%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Collaborator

@LinZexiao LinZexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinZexiao LinZexiao merged commit 3ab2fb9 into master Nov 15, 2023
1 check passed
@LinZexiao LinZexiao deleted the fix/sync-wallet-account branch November 15, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants