From cef7890ccecf7d9353b9731e829adfc13dbe8447 Mon Sep 17 00:00:00 2001 From: "Michael Bradley, Jr" Date: Tue, 14 May 2019 11:31:51 -0500 Subject: [PATCH] build: change min node version to 8.3.0 Also adjust Travis CI config to perform builds and tests with node 8. `npm install`, `npm run build`, and `npm run test` all succeeded locally with node version `8.3.0`. The reason for version `8.3.0` instead of `8.0.0` is that `8.3.0` introduced support for object rest/spread, which is used by at least one of this package's devDependencies (`go-ipfs-dep`). It may be the case that at runtime older versions of node would work correctly with the built package, but it seems simpler to settle on the minimum supported version being a version that can build, test, and use the package. Closes #983. --- .travis.yml | 1 + package.json | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 912ef7ac7..7428d50be 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,6 +7,7 @@ stages: node_js: - '10' + - '8' os: - linux diff --git a/package.json b/package.json index de974ca9a..608b51511 100644 --- a/package.json +++ b/package.json @@ -70,7 +70,7 @@ "through2": "^3.0.1" }, "engines": { - "node": ">=10.0.0", + "node": ">=8.3.0", "npm": ">=3.0.0" }, "repository": {