Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 Release 🚢 Shipping the Revamp 🚀 #749

Closed
13 of 15 tasks
olizilla opened this issue Aug 16, 2018 · 11 comments
Closed
13 of 15 tasks

v2.0.0 Release 🚢 Shipping the Revamp 🚀 #749

olizilla opened this issue Aug 16, 2018 · 11 comments
Assignees
Labels
exp/intermediate Prior experience is likely helpful P0 Critical: Tackled by core team ASAP

Comments

@olizilla
Copy link
Member

olizilla commented Aug 16, 2018

What needs to happen to get the revamp branch released

Work that will wait until v2.1

Start tackling these after the revamp becomes the new master branch and is tagged for a release.

@olizilla olizilla changed the title v2.0.0 Release 🚢 Shipping the Revamp 🚢 v2.0.0 Release 🚢 Shipping the Revamp 🚢 Aug 16, 2018
@olizilla olizilla changed the title v2.0.0 Release 🚢 Shipping the Revamp 🚢 v2.0.0 Release 🚢 Shipping the Revamp 🚀 Aug 16, 2018
@olizilla olizilla added revamp P0 Critical: Tackled by core team ASAP exp/intermediate Prior experience is likely helpful status/in-progress In progress labels Aug 16, 2018
This was referenced Aug 20, 2018
hacdias added a commit that referenced this issue Aug 20, 2018
One more step towards #749.

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member

hacdias commented Aug 25, 2018

@olizilla I think we should add i18n to 2.1 😄

@lidel
Copy link
Member

lidel commented Aug 25, 2018

Hm.. why wait for 2.1? We don't need to have unified crowdsourcing website set up for 2.0 (ipfs/ipfs-gui#50), but we should ship i18 files with English locale from the start.
That way if someone wants to contribute, there would be an option to create a PR on github.

@hacdias
Copy link
Member

hacdias commented Aug 26, 2018

I could start working on it but as we have the 'Export and reuse ipld-explorer' box to tick, I wonder how will translations work with dependencies. What's your thoughts?

@olizilla
Copy link
Member Author

I agree with @lidel, let's at least get the i18n plumbing in place, and add the en-us file so we can point people at it if they ask. I'll add am item to the list in this issue.

So yes, there is a chunk of code changes needed to go an replace all the hardcoded strings with intl look ups, but we need to do that anyway, and things are settling down, so let's do it! To be considerate to the work already done for the current version of webui, we should look at the language files that exist already, and see what entries can be re-used in the revamp as is.

Bonus points for reviewing our use of language for consistency, and making sure that we're sticking to the same words for the same concept everywhere.

Double bonus points for identifying where we already have a good phrase for things in the existing webui and re-using in the new one if it still makes sense, though that is a trade-off, as we do want to take the opportunity to improve the wording, but if there are phrases that are just as good in the old version, then let's reuse the one we have translations for already.

Triple bonus points for cross referencing all the language with ipfs-companion! We probably have some already translated phrases in there that can be reused.

Leave the explore section out initially. I need to talk through the options for re-using it with you all tomorrow, and we can decide how i18n will work there after that.

@hacdias
Copy link
Member

hacdias commented Aug 27, 2018

Sure, then we need to decide which library to use before starting working on it.

@olizilla
Copy link
Member Author

@hacdias didn't you already use react-intl?

@hacdias
Copy link
Member

hacdias commented Aug 27, 2018

@olizilla actually we did, yes. Didn't remember. I'll check how it works with external files.

@olizilla
Copy link
Member Author

olizilla commented Sep 4, 2018

I'm gonna update the list with

  • Upgrade all UI text to use react-intl -> i18next
  • handle ipfs connection errors.

@olizilla
Copy link
Member Author

We are super close now. We're waiting on the

We're going to bump

...of note this will impact web-ui as well, but adding multiple files is the core feature of share, where as the webui files view is useful without support for large / multi file upload.

@olizilla
Copy link
Member Author

the master branch is now revamp. Cool original flavour webui lives on at the v1 branch https://github.com/ipfs-shipyard/ipfs-webui/tree/v1

Next stop. Continuous Deployment of master to https://webui.ipfs.io in #806

@olizilla olizilla removed the revamp label Sep 27, 2018
@olizilla
Copy link
Member Author

olizilla commented Nov 6, 2018

This was shipped in js-ipfs v0.33.0 and go-ipfs v0.4.18

@olizilla olizilla closed this as completed Nov 6, 2018
@ghost ghost removed the status/in-progress In progress label Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful P0 Critical: Tackled by core team ASAP
Projects
None yet
Development

No branches or pull requests

4 participants