-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.0 Release 🚢 Shipping the Revamp 🚀 #749
Comments
One more step towards #749. License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
@olizilla I think we should add i18n to 2.1 😄 |
Hm.. why wait for 2.1? We don't need to have unified crowdsourcing website set up for 2.0 (ipfs/ipfs-gui#50), but we should ship i18 files with English locale from the start. |
I could start working on it but as we have the 'Export and reuse ipld-explorer' box to tick, I wonder how will translations work with dependencies. What's your thoughts? |
I agree with @lidel, let's at least get the i18n plumbing in place, and add the en-us file so we can point people at it if they ask. I'll add am item to the list in this issue. So yes, there is a chunk of code changes needed to go an replace all the hardcoded strings with intl look ups, but we need to do that anyway, and things are settling down, so let's do it! To be considerate to the work already done for the current version of webui, we should look at the language files that exist already, and see what entries can be re-used in the revamp as is. Bonus points for reviewing our use of language for consistency, and making sure that we're sticking to the same words for the same concept everywhere. Double bonus points for identifying where we already have a good phrase for things in the existing webui and re-using in the new one if it still makes sense, though that is a trade-off, as we do want to take the opportunity to improve the wording, but if there are phrases that are just as good in the old version, then let's reuse the one we have translations for already. Triple bonus points for cross referencing all the language with ipfs-companion! We probably have some already translated phrases in there that can be reused. Leave the explore section out initially. I need to talk through the options for re-using it with you all tomorrow, and we can decide how i18n will work there after that. |
Sure, then we need to decide which library to use before starting working on it. |
@hacdias didn't you already use react-intl? |
@olizilla actually we did, yes. Didn't remember. I'll check how it works with external files. |
I'm gonna update the list with
|
We are super close now. We're waiting on the
We're going to bump
...of note this will impact web-ui as well, but adding multiple files is the core feature of share, where as the webui files view is useful without support for large / multi file upload. |
the Next stop. Continuous Deployment of master to https://webui.ipfs.io in #806 |
This was shipped in js-ipfs v0.33.0 and go-ipfs v0.4.18 |
What needs to happen to get the revamp branch released
Integrate file share app. v1.0.0 Release 🚀 ipfs-shipyard/ipfs-share-files#11master
(see Meta: Translation Project for IPFS GUIs ipfs-gui#50 (comment))
Work that will wait until v2.1
Start tackling these after the revamp becomes the new master branch and is tagged for a release.
The text was updated successfully, but these errors were encountered: