This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
feat!: IPNS routing based on IPIP-351 or IPIP-379 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
commented
Aug 9, 2023
hacdias
commented
Aug 9, 2023
lidel
changed the title
lidel
suggested changes
Aug 9, 2023
There was a problem hiding this comment.
Thank you for cleaning this up.
Perhaps we could clean up bit more – see DefaultKuboRPC comment inline.
We haven't had testing before and it seems a bit complicated to automate. I tried locally with both Kubo gateway and Routing V1 and it worked partying_face
I think this is already handled by gateway-conformance, it runs in CI and since #181 we also test IPNS content paths, including raw ipns-record fixtures imported in .github/workflows/gateway-conformance.yml.
So no need for additional testing imo. 👍
|
Ping @lidel |
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Ensures IPNS_RECORD_GATEWAY_URL is prefered, then we fallback to PROXY_GATEWAY_URL, and finally KUBO_RPC_URL
lidel
approved these changes
Oct 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #151, allows resolving IPNS without
KUBO_RPC_URLbeing setIPNS_RECORD_GATEWAY_URLKUBO_RPC_URLor modernIPNS_RECORD_GATEWAY_URLorPROXY_GATEWAY_URLwith support forapplication/vnd.ipfs.ipns-recordresponsesNot sure what to do regarding testing here. We haven't had testing before and it seems a bit complicated to automate. I tried locally with both Kubo gateway and Routing V1 and it worked 🥳