add wasm build option for filewriter flags[skip changelog]

[mar1n3r0]

No description provided.

[welcome]

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

• The context for this PR is clear, with relevant discussion, decisions
  and stakeholders linked/mentioned.

• Your contribution itself is clear (code comments, self-review for the
  rest) and in its best form. Follow the code contribution
  guidelines
  if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

• A maintainer will triage and assign priority to this PR, commenting on
  any missing things and potentially assigning a reviewer for high
  priority items.

• The PR gets reviews, discussed and approvals as needed.

• The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

[Jorropo]

This looks wrong to me, right now it is a list of compatible GOOSes but you are adding a GOARCH.

If windows added support for running WASM binaries this would be incorrect.

What do you think of:

//go:build darwin || linux || netbsd || openbsd || freebsd || dragonfly || js || wasip1

?

[mar1n3r0]

Yep, totally makes sense.

[Jorropo]

LGTM thx

[Jorropo]

I can't apply the suggestions, could you do it please ?

[mar1n3r0]

I can't apply the suggestions, could you do it please ?

All set.

[mar1n3r0]

Sorry, forgot about that. Done.

…

On Fri, Aug 18, 2023 at 2:06 PM Henrique Dias ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In files/filewriter_unix_test.go <#411 (comment)>: > @@ -1,4 +1,4 @@ -//go:build darwin || linux || netbsd || openbsd +//go:build darwin || linux || netbsd || openbsd || freebsd || dragonfly || wasm @mar1n3r0 <https://github.com/mar1n3r0> this suggestion is still missing, can you pls apply it? — Reply to this email directly, view it on GitHub <#411 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWZIOOXQRXZX6VCLHE2JP3XV5EDHANCNFSM6AAAAAA2MTY5GM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[codecov]

Codecov Report

Merging #411 (a051a02) into main (cfad09d) will decrease coverage by 0.18%.
Report is 18 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   49.61%   49.44%   -0.18%     
==========================================
  Files         248      246       -2     
  Lines       29838    29946     +108     
==========================================
+ Hits        14805    14806       +1     
- Misses      13615    13703      +88     
- Partials     1418     1437      +19     

Files Changed	Coverage Δ
files/filewriter_unix.go	100.00% <ø> (ø)

... and 28 files with indirect coverage changes