Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing V1 CLI Example #479

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Routing V1 CLI Example #479

merged 2 commits into from
Oct 5, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Oct 4, 2023

  • Exposes routing/http/client.Client so that users can actually use it across their code.
  • Adds Routing V1 CLI example. Added some basic tests.

I will use this example for my talk in IPFS Connect and I thought it was useful to keep here.

@hacdias hacdias requested a review from a team as a code owner October 4, 2023 12:10
@hacdias hacdias self-assigned this Oct 4, 2023
@hacdias hacdias force-pushed the routing-v1-client-example branch 2 times, most recently from a58f2a2 to 545288c Compare October 4, 2023 12:15
@hacdias hacdias marked this pull request as draft October 4, 2023 12:16
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #479 (cb005d8) into main (5ae64f3) will decrease coverage by 0.06%.
The diff coverage is 57.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   65.69%   65.64%   -0.06%     
==========================================
  Files         208      209       +1     
  Lines       25099    25196      +97     
==========================================
+ Hits        16488    16539      +51     
- Misses       7152     7189      +37     
- Partials     1459     1468       +9     
Files Coverage Δ
routing/http/client/client.go 74.59% <100.00%> (ø)
examples/routing/delegated-routing-client/main.go 51.54% <51.54%> (ø)

... and 10 files with indirect coverage changes

@hacdias hacdias requested a review from lidel October 4, 2023 14:20
@hacdias hacdias marked this pull request as ready for review October 4, 2023 14:20
examples/routing-v1/client/README.md Outdated Show resolved Hide resolved
examples/routing-v1/client/README.md Outdated Show resolved Hide resolved
examples/routing-v1/client/main.go Outdated Show resolved Hide resolved
examples/routing-v1/client/README.md Outdated Show resolved Hide resolved
@hacdias hacdias requested a review from lidel October 4, 2023 17:25
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small nits below

examples/README.md Outdated Show resolved Hide resolved
examples/routing/delegated-routing-client/main.go Outdated Show resolved Hide resolved
@hacdias hacdias enabled auto-merge (rebase) October 5, 2023 09:54
@hacdias hacdias merged commit b388690 into main Oct 5, 2023
13 checks passed
@hacdias hacdias deleted the routing-v1-client-example branch October 5, 2023 10:14
@BigLep BigLep mentioned this pull request Nov 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants