generated from ipfs/ipfs-repository-template
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routing V1 CLI Example #479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
force-pushed
the
routing-v1-client-example
branch
2 times, most recently
from
October 4, 2023 12:15
a58f2a2
to
545288c
Compare
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
==========================================
- Coverage 65.69% 65.64% -0.06%
==========================================
Files 208 209 +1
Lines 25099 25196 +97
==========================================
+ Hits 16488 16539 +51
- Misses 7152 7189 +37
- Partials 1459 1468 +9
|
hacdias
force-pushed
the
routing-v1-client-example
branch
from
October 4, 2023 14:20
545288c
to
cc1f46a
Compare
lidel
reviewed
Oct 4, 2023
lidel
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, small nits below
hacdias
force-pushed
the
routing-v1-client-example
branch
from
October 5, 2023 06:05
3461457
to
8206414
Compare
hacdias
force-pushed
the
routing-v1-client-example
branch
from
October 5, 2023 09:54
8206414
to
cb005d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
routing/http/client.Client
so that users can actually use it across their code.I will use this example for my talk in IPFS Connect and I thought it was useful to keep here.