Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove util.MultiErr #491

Merged
merged 1 commit into from
Oct 17, 2023
Merged

feat!: remove util.MultiErr #491

merged 1 commit into from
Oct 17, 2023

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Oct 17, 2023

Self-explanatory. Not used anywhere I could find. Boxo supports Go 1.21+. There are native ways of doing this. Cleanup is always good. It's funny we have our own multi error while we've just been using Uber's and others this whole time.

@hacdias hacdias self-assigned this Oct 17, 2023
@hacdias hacdias requested a review from a team as a code owner October 17, 2023 14:52
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #491 (77cdac9) into main (8660c62) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   65.68%   65.74%   +0.06%     
==========================================
  Files         207      207              
  Lines       25141    25130      -11     
==========================================
+ Hits        16513    16522       +9     
+ Misses       7166     7147      -19     
+ Partials     1462     1461       -1     
Files Coverage Δ
util/util.go 39.34% <ø> (+6.01%) ⬆️

... and 12 files with indirect coverage changes

Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure if anyone is actually using this, but if so it's a good opportunity to move them along.

@hacdias hacdias merged commit aa6fa14 into main Oct 17, 2023
14 checks passed
@hacdias hacdias deleted the remove-multierr branch October 17, 2023 15:55
@BigLep BigLep mentioned this pull request Nov 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants