Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): do not act on template errors #515

Merged
merged 3 commits into from
Nov 22, 2023

feat: write error on template execution error

5bfcf4f
Select commit
Loading
Failed to load commit list.
Merged

fix(gateway): do not act on template errors #515

feat: write error on template execution error
5bfcf4f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 22, 2023 in 0s

65.52% (-0.07%) compared to fe55533

View this Pull Request on Codecov

65.52% (-0.07%) compared to fe55533

Details

Codecov Report

Merging #515 (5bfcf4f) into main (fe55533) will decrease coverage by 0.07%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   65.58%   65.52%   -0.07%     
==========================================
  Files         207      207              
  Lines       25540    25543       +3     
==========================================
- Hits        16750    16736      -14     
- Misses       7323     7335      +12     
- Partials     1467     1472       +5     
Files Coverage Δ
gateway/handler_unixfs_dir.go 67.27% <100.00%> (ø)
gateway/handler_codec.go 62.85% <60.00%> (+0.77%) ⬆️
gateway/errors.go 83.33% <25.00%> (-2.14%) ⬇️
gateway/handler.go 76.54% <0.00%> (-0.14%) ⬇️

... and 7 files with indirect coverage changes