Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helper to approximate test creation patter from ipfs-files #32

Merged
merged 1 commit into from
May 4, 2022

Conversation

willscott
Copy link
Collaborator

There are common in-memory creations of small unixfs directory trees. This provides an easily portable API to do the same with the new ipld-prime linksystem / unixfsnode creation tools.

@willscott willscott requested a review from rvagg May 2, 2022 09:38
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!
my only quibble is the use of Node, we're overloading that term a lot around here and maybe an alternative would have less potential for confusion. Entry, Element, Part?

@willscott
Copy link
Collaborator Author

this was named so that it's an easy port from go-ipfs-files

@rvagg
Copy link
Member

rvagg commented May 4, 2022

bleh

your call though if you're happy with it

@willscott willscott merged commit 650a615 into main May 4, 2022
@willscott willscott deleted the quickbuilder branch May 4, 2022 07:11
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 12, 2023
add helper to approximate test creation patter from ipfs-files

This commit was moved from ipfs/go-unixfsnode@650a615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants