This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: update dht tests #383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
35 tasks
vasco-santos
force-pushed
the
fix/dht-put-and-get
branch
from
572194e
to
d77e7c1
Compare
daviddias
approved these changes
Nov 3, 2018
There was a problem hiding this comment.
@vasco-santos do you confirm that these pass with latest js-ipfs-api and latest js-ipfs?
|
|
vasco-santos
force-pushed
the
fix/dht-put-and-get
branch
3 times, most recently
from
91e5259
to
60e089d
Compare
vasco-santos
force-pushed
the
fix/dht-put-and-get
branch
from
60e089d
to
3450077
Compare
alanshaw
pushed a commit
that referenced
this pull request
May 31, 2019
closes #383 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Merged
alanshaw
pushed a commit
that referenced
this pull request
May 31, 2019
closes #383 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, a currently broken test is skipped and a new test was added to both
dht.getanddht.put.In the context of js-ipfs#856 and more precisely js-ipfs#856#issuecomment-435507070.
Needs: