Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open Preferences in a new tab #879

Merged
merged 12 commits into from
May 15, 2020
Merged

feat: open Preferences in a new tab #879

merged 12 commits into from
May 15, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented May 8, 2020

Closes #502

This PR opens Preferences in a new tab, which makes it look the same in every browser.

TODO

  • update manifest
  • remove vendor-specific quirks and hacks
  • improve styling of add-on/src/options/options.css|html
  • test styling at various responsive widths for both Chrome and Firefox

@jessicaschilling as you suggested in #502 (comment) I've made the backend changes, it works, but needs style work to make it look decent

Shortcuts to build & preview:

  • yarn dev-build firefox
  • yarn dev-build chromium

Works, but requires refinement of options HTML page and CSS
@jessicaschilling
Copy link
Contributor

@lidel Thanks! Do you mind reviewing the updated links to documentation so we can get those merged in before I start on this?

Works, but requires refinement of options HTML page and CSS
@lidel lidel force-pushed the feat/preferences-tab branch from 53fa339 to 23231b2 Compare May 10, 2020 19:54
@lidel
Copy link
Member Author

lidel commented May 10, 2020

@jessicaschilling I've rebased this PR on top of #871 – should be ok to work on this now 👍

@jessicaschilling
Copy link
Contributor

@lidel - FYI, it's getting there in the most recent commit I pushed, but still want to do some more tweaking. It's looking a lot like Web UI prefs now.

@lidel
Copy link
Member Author

lidel commented May 13, 2020

Nice! It is already much better!

Small nit: seems color used for .link changed, and that impacts other screens (eg. welcome page).

@jessicaschilling
Copy link
Contributor

@lidel - thanks for the reminder on the welcome screen. There's a few things I'd like to tweak there anyway.

@lidel
Copy link
Member Author

lidel commented May 14, 2020

On preferences

I think its already much better than it was and we should merge, but the background color of inputs is bit aggressive:

2020-05-14--20-16-04

Perhaps we can use something more subtle? old version used white background and border, here we probably could also use white and color accent on the bottom, perhaps?

On welcome screen

Hm... now those colorful links distract from the content / feel noisy:

2020-05-14--20-08-40

Could we move in the other direction, and make links have the same color as text, but make the underline in this color?

For the reference, current master with underline in the same color as text:

2020-05-14--20-12-55

@jessicaschilling jessicaschilling marked this pull request as ready for review May 14, 2020 19:21
@jessicaschilling
Copy link
Contributor

@lidel - made some tweaks as we discussed on Slack. I think this might be ready to go. Had a look around in both FF and Chrome.

I'd like to do something more interesting with the header - like bring the heartbeat cube back in if Companion is active - but that's something for later.

Thanks!

Copy link
Member Author

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's...

@lidel lidel merged commit c2c3f6b into master May 15, 2020
@lidel lidel deleted the feat/preferences-tab branch May 15, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open preferences in new tab for vendor consistency
2 participants