-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: open Preferences in a new tab #879
Conversation
Works, but requires refinement of options HTML page and CSS
@lidel Thanks! Do you mind reviewing the updated links to documentation so we can get those merged in before I start on this? |
Works, but requires refinement of options HTML page and CSS
53fa339
to
23231b2
Compare
@jessicaschilling I've rebased this PR on top of #871 – should be ok to work on this now 👍 |
@lidel - FYI, it's getting there in the most recent commit I pushed, but still want to do some more tweaking. It's looking a lot like Web UI prefs now. |
Nice! It is already much better! Small nit: seems color used for |
…-hand-side links in welcome screen
@lidel - thanks for the reminder on the welcome screen. There's a few things I'd like to tweak there anyway. |
On preferencesI think its already much better than it was and we should merge, but the background color of inputs is bit aggressive: Perhaps we can use something more subtle? old version used white background and border, here we probably could also use white and color accent on the bottom, perhaps? On welcome screenHm... now those colorful links distract from the content / feel noisy: Could we move in the other direction, and make links have the same color as text, but make the underline in this color? For the reference, current |
@lidel - made some tweaks as we discussed on Slack. I think this might be ready to go. Had a look around in both FF and Chrome. I'd like to do something more interesting with the header - like bring the heartbeat cube back in if Companion is active - but that's something for later. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR opens Preferences in a new tab, which makes it look the same in every browser.
TODO
add-on/src/options/options.css|html
@jessicaschilling as you suggested in #502 (comment) I've made the backend changes, it works, but needs style work to make it look decent
Shortcuts to build & preview:
yarn dev-build firefox
yarn dev-build chromium