Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Check for Updates.." menu item gives no feedback #1378

Closed
andrew opened this issue Mar 18, 2020 · 7 comments · Fixed by #1414
Closed

"Check for Updates.." menu item gives no feedback #1378

andrew opened this issue Mar 18, 2020 · 7 comments · Fixed by #1414
Labels
area/macos MacOS effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-content Content design, writing, information architecture topic/design-front-end Front-end implementation of UX/UI work

Comments

@andrew
Copy link
Contributor

andrew commented Mar 18, 2020

Screenshot 2020-03-18 at 15 50 16

When I click on the "check for updates" menu item in MacOS (Catalina), I get no visual feedback on what is happening, if there is a new release or if I'm on the latest one.

One thing to note is that I didn't allow notifications for IPFS desktop, so if it's trying to communicate only via native notifications then I wouldn't see it, but that's also very non-standard for Mac os apps.

Expected behavior: I would expect there to be a pop up window that either gave details of a new release that's available to download (related issue #1210) or a message that says I'm on the latest version, like Zoom does:

Screenshot 2020-03-18 at 15 59 36

@lidel
Copy link
Member

lidel commented Mar 18, 2020

Thank you, that is very good feedback and I am pretty sure blocked notification is the case:

https://github.com/ipfs-shipyard/ipfs-desktop/blob/ace72b21cb670f29fedad852e10c803010bf9ab5/src/auto-updater/index.js#L12-L17

Potential fix here would be to display pop up when userRequested is true

@lidel lidel added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue area/macos MacOS UX labels Mar 18, 2020
@hacdias
Copy link
Member

hacdias commented Mar 26, 2020

On my computer, I get a notification:

Screenshot 2020-03-26 at 15 41 41

I know that if there's a version available, it will take a lot more time to get a notification though.

@hacdias
Copy link
Member

hacdias commented Mar 26, 2020

@lidel

Potential fix here would be to display pop up when userRequested is true

That's what's happening

@andrew
Copy link
Contributor Author

andrew commented Mar 26, 2020

@hacdias part of the problem is that if you don't enable notifications for the ipfs desktop app when you first install it on mac os (because not everyone likes apps to be able to randomly interrupt you with pings), then you don't see anything happen.

@hacdias
Copy link
Member

hacdias commented Mar 26, 2020

Ooooh, I understand what you mean then. We actually rely a lot on notifications. Personally, I wouldn't mind to use dialogs for some actions such as this.

Wdyt?

/cc @lidel

@andrew
Copy link
Contributor Author

andrew commented Mar 27, 2020

+1 for dialogs that are direct responses to UI actions

@jessicaschilling jessicaschilling added topic/design-front-end Front-end implementation of UX/UI work topic/design-ux UX strategy, research, not solely visual design and removed UX labels Mar 30, 2020
@jessicaschilling
Copy link
Contributor

+1 for @andrew's notes on this being a much more prevalent interaction pattern for a dialog, not a notification. I'd like to try to queue this up for as soon as we have developer resources; happy to provide language for the dialog text.

@jessicaschilling jessicaschilling added effort/hours Estimated to take one or several hours good first issue Good issue for new contributors kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-content Content design, writing, information architecture and removed topic/design-ux UX strategy, research, not solely visual design labels Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/macos MacOS effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked topic/design-content Content design, writing, information architecture topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants