Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable update check in dev #1422

Closed
lidel opened this issue Apr 18, 2020 · 1 comment · Fixed by #1423
Closed

Disable update check in dev #1422

lidel opened this issue Apr 18, 2020 · 1 comment · Fixed by #1423
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented Apr 18, 2020 •
edited
Loading

https://github.com/ipfs-shipyard/ipfs-desktop/pull/1414/files#diff-a35e38cd4254c7195bafd538c087d2e5L73 was removed in #1414, and now every time we run npm start during development it pings the update server(?) on each run:

$ DEBUG='desktop' npm start                                                                                                                                                                 ... feat/ipfsd-ctl-update
                  
> ipfs-desktop@0.10.4 start /home/lidel/project/ipfs-desktop
> cross-env NODE_ENV=development electron src/index.js

2020-04-18T14:12:11.054Z info: [meta] logs can be found on /home/lidel/.config/Electron
Checking for update
Generated new staging user ID: bde5278b-16e6-55f6-8b5d-777509b33c87
Update for version 8.2.3 is not available (latest version: 0.10.4, downgrade is disallowed).
2020-04-18T14:12:14.118Z info: [updater] update not available

cc @hacdias – thoughts?
@lidel lidel added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up kind/maintenance Work required to avoid breaking changes or harm to project's status quo effort/hours Estimated to take one or several hours status/ready Ready to be worked labels Apr 18, 2020
@hacdias
Copy link
Member

hacdias commented Apr 18, 2020

Ah. I (enabled) it on dev so I could test the different dialogs. I can disable it again, of course.

@hacdias hacdias mentioned this issue Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disable updates in development ipfs/ipfs-desktop
2 participants
@lidel @hacdias