Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apple guidelines macOS compliant icon #1256

Merged
merged 5 commits into from
Nov 29, 2019
Merged

feat: apple guidelines macOS compliant icon #1256

merged 5 commits into from
Nov 29, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Nov 22, 2019

After much discussion on #956, I decided to keep it simple and just change the menubar icon on macOS since it is the only platform where we are actually violating the guidelines.

Secondly, after a lot of discussion (again!) about how to differentiate between an online and offline node, I decided to go with the most simple solution and follow what some other tools do: just dim the icon when it's offline

@ericronne I used your last icon. However, I needed to resize it because it had a lot of white space surrounding it. Since it's a real pixel perfect work, I ask you to take a look at this screenshots to see if they look good or not, please.

Screenshot 2019-11-22 at 06 13 41

Screenshot 2019-11-22 at 06 13 36

Screenshot 2019-11-22 at 06 13 29

Screenshot 2019-11-22 at 06 13 21

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@lidel
Copy link
Member

lidel commented Nov 23, 2019

If we use dimming for status, do we still need dots in corners?
Perhaps a simple cube would be enough (and give more canvas for pixels)

@hacdias
Copy link
Member Author

hacdias commented Nov 23, 2019

@lidel it works for me. Wdyt @ericronne ?

@ericronne
Copy link

Sure, thx!

@hacdias
Copy link
Member Author

hacdias commented Nov 25, 2019

@ericronne could you make a small cube icon with stronger outlines so we can apply it here, please?

@ericronne
Copy link

Here's both a plain option one with node dots on the corners. The plain version better represents the most widely used ipfs logo, but it's also more generic ...
image
plain .svg

I'd recommend the dotted version …
image
dotted .svg

@hacdias
Copy link
Member Author

hacdias commented Nov 26, 2019

Let's vote!

🎉 for

image

🚀 for

image

Poll will be closed Friday and merged!

@hacdias
Copy link
Member Author

hacdias commented Nov 26, 2019

PS: our icon is perfectly centered. Other might not and cause the sensation of not being centered.

@hacdias
Copy link
Member Author

hacdias commented Nov 26, 2019

@autonome
Copy link
Contributor

In isolation and enlarged, the dotted version looks ok. However, when in the menubar it no longer looks easily recognizable as IPFS - the large dots make it look circular, a bit like a ship's wheel.

I recommend using either the generic-but-more-obviously-IPFS icon or experimenting with smaller dots.

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented Nov 29, 2019

Say hello to the winner and to the next "generation" IPFS Desktop on macOS icon:

image

@hacdias hacdias merged commit 48ef20e into master Nov 29, 2019
@hacdias hacdias deleted the feat/new-icons branch November 29, 2019 09:27
This was referenced Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants