-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: apple guidelines macOS compliant icon #1256
Conversation
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
If we use dimming for status, do we still need dots in corners? |
@lidel it works for me. Wdyt @ericronne ? |
Sure, thx! |
@ericronne could you make a small cube icon with stronger outlines so we can apply it here, please? |
Here's both a plain option one with node dots on the corners. The plain version better represents the most widely used ipfs logo, but it's also more generic ... I'd recommend the dotted version … |
PS: our icon is perfectly centered. Other might not and cause the sensation of not being centered. |
In isolation and enlarged, the dotted version looks ok. However, when in the menubar it no longer looks easily recognizable as IPFS - the large dots make it look circular, a bit like a ship's wheel. I recommend using either the generic-but-more-obviously-IPFS icon or experimenting with smaller dots. |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
After much discussion on #956, I decided to keep it simple and just change the menubar icon on macOS since it is the only platform where we are actually violating the guidelines.
Secondly, after a lot of discussion (again!) about how to differentiate between an online and offline node, I decided to go with the most simple solution and follow what some other tools do: just dim the icon when it's offline
@ericronne I used your last icon. However, I needed to resize it because it had a lot of white space surrounding it. Since it's a real pixel perfect work, I ask you to take a look at this screenshots to see if they look good or not, please.