Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for go-ipfs 0.5 #1392

Merged
merged 5 commits into from
Apr 23, 2020
Merged

feat: support for go-ipfs 0.5 #1392

merged 5 commits into from
Apr 23, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 7, 2020

This bumps go-ipfs version to 0.5.0-rc1 in preparation for 0.5 release.

Small set of fixes was required:

  • Status check
  • Bundled ipfs-webui loaded via Electron's BrowserWindow
    • Origin header: a proper value is set instead of removing it
    • sending ipfs-desktop/${version} in User-Agent header

TODO before merge

cc @hacdias @Stebalien ipfs/kubo#7109

@lidel lidel added topic/dependencies Topic dependencies kind/maintenance Work required to avoid breaking changes or harm to project's status quo area/webui Issues specific to interaction with ipfs-webui labels Apr 7, 2020
@lidel lidel requested a review from hacdias April 7, 2020 19:14
@lidel
Copy link
Member Author

lidel commented Apr 7, 2020

Old way of dealing with CORS no longer worked, I replaced it with a proper Origin that makes request to look like its from a page loaded from API origin:

webui-desktop-2020-04-07--20-59-44

@lidel
Copy link
Member Author

lidel commented Apr 22, 2020

Rebased on master, switched to 0.5.0-rc3.
If CI is green then it should be ready for merge (we can switch to final 0.5.0 in separate PR when it is released)

@lidel lidel marked this pull request as ready for review April 22, 2020 23:37
@lidel
Copy link
Member Author

lidel commented Apr 22, 2020

Ok, I think we need to merge #1411 first – E2E tests won't pass without fixes present there.

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Apr 22, 2020
This bumps go-ipfs version to 0.5.0-rc1 in preparation for 0.5 release.

Small set of fixes was required:
- switched API calls from `GET` to `POST`
- Origin header: a proper value is set instead of removing it
- sending `ipfs-desktop/${version}` in `User-Agent` header

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
Copy link
Member

@hacdias hacdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's just wait for the tests.

@hacdias hacdias removed the status/blocked Unable to be worked further until needs are met label Apr 23, 2020
@hacdias hacdias merged commit 47e6306 into master Apr 23, 2020
@hacdias hacdias deleted the feat/go-ipfs-0.5 branch April 23, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webui Issues specific to interaction with ipfs-webui kind/maintenance Work required to avoid breaking changes or harm to project's status quo topic/dependencies Topic dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants