-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for go-ipfs 0.5 #1392
Conversation
Rebased on master, switched to 0.5.0-rc3. |
Ok, I think we need to merge #1411 first – E2E tests won't pass without fixes present there. |
This bumps go-ipfs version to 0.5.0-rc1 in preparation for 0.5 release. Small set of fixes was required: - switched API calls from `GET` to `POST` - Origin header: a proper value is set instead of removing it - sending `ipfs-desktop/${version}` in `User-Agent` header License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
df7997b
to
5836c91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's just wait for the tests.
This bumps go-ipfs version to 0.5.0-rc1 in preparation for 0.5 release.
Small set of fixes was required:
GET
toPOST
(HTTP API: Disallow GET requests kubo#7097)Origin
header: a proper value is set instead of removing itipfs-desktop/${version}
inUser-Agent
headerTODO before merge
switch from(new PR, see feat: support for go-ipfs 0.5 #1392 (comment))"v0.5.0-rc1
to"v0.5.0
when it shipscc @hacdias @Stebalien ipfs/kubo#7109