-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: node stats page #766
Conversation
Yep, that sounds good. I'm not convinced we need to show the public key in that box. Maybe there is an advanced info section that is collapsed, that has public key and the addresses the node is bound to in. I think peer id, connected peer count, and the agent version, which we can just call "version" info is worth showing up top. |
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
@olizilla more screenshots: |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias this is looking good! Some thoughts
The only issue is the is there is no support in IE or Edge: https://caniuse.com/#search=details I imagine there is a react component that polyfills the behaviour where it's not available. If not, that'd be a super helpful component to publish!
|
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
@olizilla couldn't find a component but I found a very simple plugin: https://github.com/rstacruz/details-polyfill I will make a Reacty component though. |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
@olizilla the tests started failing really randomly. Need to figure out why. DO you agree with the three graphs on Invision?
I can't see to which compare the speed to to fill the graphs. |
@hacdias good point. Like a speedometer, we can pick a max value, and if it's over the "top speed" we can just show the bar as full. We could just say that the full is 100MB/s. If we want it to be more visually exciting, then we could use a non-linear scale, that gives more space to lower numbers and bunches up higher numbers like http://www.speedtest.net/ does. I'm not sure we want to play those games though. I do think it's a good thing to have the storage graph look empty if there is very little in your repo! |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
@olizilla I'll open this to review. In the meanwhile, if anyone can discover why are the tests failing in the CI with It seems to have started after 2d41077, which doesn't appear to have nothing to do with navigation. Maybe it increased the rendering time? |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
@olizilla done! 😉 |
I get duplicate react key errors, as it seems I have the same address twice in my list! @hacdias this is clearly weird, but we should make the UI robust to that. Can you filter the list to contain only unique entries. I think they should be in monospace too, but they are showing up as sans-serif now. Same for the public key. In another PR it'd be great to group them by ip4 and ip6, and pick out the ip address section in a different color, so users can quickly pick out what network interfaces their node is bound to. |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
@olizilla just made some updates. If I recall correctly, you told me you were making some changes this afternoon? Did you commit them? |
Adds a node stats bundle.
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io