Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Locale for Chinese (China) to zh-CN #786

Merged
merged 1 commit into from
Sep 8, 2018
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 8, 2018

Received some useful hints from our friends at Transifex and I think this approach is the way to go forward.

This PR applies revised naming convention from ipfs/ipfs-gui#50 (comment)

  • Renames Chinese locale from zh to zh-CN, which is supported by i18next and match value from Accept-Language:

    screenshot

I smoke tested this PR and strings that are already translated rendered correctly:

screenshot_5

ps. In the future we can add pt-BR and en-GB using the same convention :)

@lidel lidel requested review from olizilla and hacdias September 8, 2018 19:25
@lidel
Copy link
Member Author

lidel commented Sep 8, 2018

This is basically #784 but with changed code, so safe to merge.

@lidel lidel merged commit 6144b5f into revamp Sep 8, 2018
@lidel lidel deleted the fix/chinese-translation branch September 8, 2018 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants