Rename Locale for Chinese (China) to zh-CN #786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Received some useful hints from our friends at Transifex and I think this approach is the way to go forward.
This PR applies revised naming convention from ipfs/ipfs-gui#50 (comment)
zh
tozh-CN
, which is supported byi18next
and match value fromAccept-Language
:I smoke tested this PR and strings that are already translated rendered correctly:
ps. In the future we can add
pt-BR
anden-GB
using the same convention :)