perf: decrease wantlist send debounce time #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We wait 200ms before sending wantlists to remote peers which is an eternity. I'm not sure how this figure was arrived at but I've reduced it to 10ms which has increased the js->js transfer times in the interop tests to: | Data | 200ms | 10ms | Speedup | |---------|----------|---------|---------| | 1.02 kB | 486ms | 142ms | 342% | | 63.5 kB | 449ms | 119ms | 377% | | 65.5 kB | 436ms | 105ms | 415% | | 524 kB | 1287ms | 210ms | 613% | | 786 kB | 1676ms | 282ms | 594% | | 1.05 MB | 2066ms | 326ms | 634% | | 1.05 MB | 2123ms | 330ms | 643% | | 4.19 MB | 7091ms | 1045ms | 679% | | 8.39 MB | 13711ms | 1927ms | 712% | | 67.1 MB | 107704ms | 13462ms | 800% | | 134 MB | 214988ms | 26038ms | 826% |
hugomrdias
approved these changes
May 26, 2020
|
Running with different debounce times and counting the network packets transmitted between nodes (pinning is disabled so the overall time is a lot less):
By comparison, go-ipfs@0.5.1 running the same test:
Based on this we should probably disable the debounce entirely. |
…ist-send-debounce
dirkmc
reviewed
May 27, 2020
dirkmc
approved these changes
May 27, 2020
There was a problem hiding this comment.
LGTM 👍
I removed a similar 100ms debounce from the engine (bitswap server side) recently.
The reason it may be useful to have a small debounce on the client is that when sending wants it's better to send 10 wants in a single wantlist rather than 10 messages with an individual want in each one. In go-bitswap we use a 1ms debounce.
dirkmc
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We debounce sending wantlists to remote peers by 200ms which is an eternity. I'm not sure how this figure was arrived at but I've reduced it to 10ms which has increased the js->js transfer times in the "exchange files" interop tests to: