This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Show room feature in Exchange Files Example #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niinpatel
changed the title
niinpatel
force-pushed
the
docs/exchange-files-room-feature
branch
3 times, most recently
from
13b597a
to
3f06b70
Compare
niinpatel
changed the title
|
That is super cool @niinpatel 🚀 - I'll review as soon as I have a sec! |
License: MIT Signed-off-by: Nitin Patel <nitinpatel278@gmail.com>
niinpatel
force-pushed
the
docs/exchange-files-room-feature
branch
from
3f06b70
to
f50da52
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #1632, currently, it is impossible to guess that there is the room feature on the exchange files example.
So, I added a textbox and a button which can be used for subscribing to a different room. Here's a small preview of the feature:
closes #1632