LinkSize > 0 even when NumLinks === 0

[daviddias]

» ipfs object stat QmeGYYkoAwJWooGSoW9Lx1rEmkDfqpTXgGR4hCs7yDV6Wx
NumLinks: 0
BlockSize: 126
LinksSize: 2
DataSize: 124
CumulativeSize: 126

Is there any reason I'm missing on why it is 2?

[rht]

See https://github.com/ipfs/go-ipfs/blob/06cb9b5813a2fb15d57267bc72268ffbe32ea796/merkledag/node.go#L239 for how the LinksSize is determined.

The protobuf marshal additionally adds offset with https://github.com/ipfs/go-ipfs/blob/06cb9b5813a2fb15d57267bc72268ffbe32ea796/merkledag/pb/merkledag.pb.go#L556.

[daviddias]

oh, I see. Thank you @rht :)

[rht]

(I'd consider it a bug. LinksSize can already be determined accurately through the sum of the size of the links. It doesn't make sense to put anything associated with the data to the links (this is certain). The framing and the encoded links should have been put into DataSize can be figured from BlockSize-DataSize.)

[whyrusleeping]

yeah, that doesnt seem right to me. the comment is vague, i'm not sure what is meant to 'include framing'. with zero links, linksize should be zero

[whyrusleeping]

This should be resolved now. The links field is normalized to be null if no links are present. The two bytes was caused by a non-null but zero length links array in the protobuf

[daviddias]

So, just to be sure, do we put an empty array on the protobuf taking those couple of bytes?