ipfs name publish --lifetime option documentation inconsistent

[RichardLitt]

$  ipfs name publish --help
...
    -t,      --lifetime string - time duration that the record will be valid for (default: 24hrs)
...

Note that 24hrs is given as a default. However, this is not valid when passed in:

$ ipfs name publish QmW2WQi7j6c7UgJTarActp7tDNikE4B2qXtFCfLPdsgaTQ --lifetime=24hrs
Error: error parsing lifetime option: time: unknown unit hrs in duration 24hrs

How can I use the lifetime option?

[hackergrrl]

Go's time.ParseDuration would expect the h suffix, not hrs. Great that you caught this. 👍

The parser is surprisingly flexible: I can make records valid for 10h43s15µs!

func ParseDuration(s string) (Duration, error)
    ParseDuration parses a duration string. A duration string is a possibly
    signed sequence of decimal numbers, each with optional fraction and a
    unit suffix, such as "300ms", "-1.5h" or "2h45m". Valid time units are
    "ns", "us" (or "µs"), "ms", "s", "m", "h".

In the future we might want to move to our own parser though, since there's no support for days, months, years, and any other larger units that'd be commonly desirable for TTLs.

[RichardLitt]

What do you we say just include that paragraph about ParseDuration in the docs, here, for now? Thanks for figuring this out, I was a bit lost.

[hackergrrl]

🐴SGTM

Maybe

    -t,      --lifetime string - time duration that the record will be valid for (default: 24h)

    This accepts durations such as "300s", "1.5h" or "2h45m". Valid time units are
    "ns", "us" (or "µs"), "ms", "s", "m", "h".