IPFS doesn't accept multibase IPNS addresses

[Stebalien]

Version information:

go-ipfs version: 0.4.9-8ec0814a
Repo version: 5
System version: amd64/linux
Golang version: go1.8.3

Type:

Enhancement?

Severity:

Low

Description:

IPFS doesn't accept multibase IPNS addresses. For example, try fetching wikipedia with a multibase prefix:

ipfs cat /ipns/zQmdJiuMWp2FxyaerfLrtdLF6Nr1EWpL7dPAxA9oKSPYYgV/wiki/index.html

[whyrusleeping]

hrm... Should we add a cid multicodec for ipns?

[Stebalien]

Lately, I've been thinking of generalizing CIDv0: multiformats/cid#12

But yes, the alternative is to just say Qm... in /ipns/Qm... is not a CID, SomethingElse in /ipns/SomethingElse is.

[kevina]

Note: There is some debate is CidV0 hashes should even be allowed a multibase prefix so I'm not sure the correct thing to do here.

[Stebalien]

@kevina at the moment, IPNS addresses aren't CIDs. They're just raw multihashes (that point to special protocol buffers, not IPLD nodes).

[reardenlife]

@whyrusleeping

"hrm... Should we add a cid multicodec for ipns?"

Was it ever implemented -- the CIDv1 for IPNS?

[lidel]

Done. IPNS support for multibase names being CIDv1 with libp2p-key codec was implemented around the time #7441 landed 🐈
See https://github.com/libp2p/specs/blob/master/RFC/0001-text-peerid-cid.md