Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mounts detect unmounts and track mount state. #2296

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

hackergrrl
Copy link
Contributor

This lets FUSE mounts to track whether they are active or not by
tracking when fs.Serve terminates.

License: MIT
Signed-off-by: Stephen Whitmore noffle@ipfs.io

@whyrusleeping
Copy link
Member

this looks pretty good to me. Wanna throw together a test for it? might be easy to do in go code

@hackergrrl
Copy link
Contributor Author

Thanks! I almost have the test ready, but I'm doing a small refactor to make it fit in more cleanly.

@hackergrrl
Copy link
Contributor Author

All right! Assuming Travis smiles upon my patch, please take another look. :)

@dignifiedquire
Copy link
Member

@noffle travis no smile on you

@hackergrrl
Copy link
Contributor Author

I see: I was missing a source file in the new package that offered Mount when no_fuse was enabled. I need to get better at running tests locally with fuse turned off as well.

This lets FUSE mounts to track whether they are active or not by
tracking when fs.Serve terminates.

License: MIT
Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
@hackergrrl
Copy link
Contributor Author

squashed. will merge when CI gives green again.

hackergrrl pushed a commit that referenced this pull request Feb 8, 2016
Mounts detect unmounts and track mount state.
@hackergrrl hackergrrl merged commit e9cc395 into ipfs:master Feb 8, 2016
@whyrusleeping
Copy link
Member

@noffle wait for either @jbenet or myself to merge PRs please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants