Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands Refactor Part 1 #262

Merged
merged 66 commits into from
Nov 4, 2014
Merged

Commands Refactor Part 1 #262

merged 66 commits into from
Nov 4, 2014

Conversation

jbenet
Copy link
Member

@jbenet jbenet commented Nov 4, 2014

We split #196 in two parts. this is the first. it only has the commands/ directory.

@jbenet jbenet added the status/in-progress In progress label Nov 4, 2014
This was referenced Nov 4, 2014
Closed
Closed
@jbenet
Copy link
Member Author

jbenet commented Nov 4, 2014

@maybebtc can you look this over and confirm?

You may want to pull down both cmd-ref-part1 and cmd-ref-part2 and verify changes against commands-refactor.

mappum and others added 26 commits November 4, 2014 02:04
@mappum @jbenet
commands: Made Response#Error return an *Error instead of an error
19e5fba
@mappum @jbenet
commands: Removed unused output stream field from Response
94683bb
@mappum @jbenet
commands: Made Response implement io.Reader
3cebd21
@mappum @jbenet
commands: Simplified Error string output
e8b37ac
@mappum @jbenet
commands: Added Request#Options so consumers can iterate through prov…
a65c99e 
…ided options
@mappum @jbenet
commands/http: Moved HTTP RPC into commands/http package
8b61daa
@mappum @jbenet
commands/http: Moved HTTP RPC handler into commands/http
43c61a4
@mappum @jbenet
commands: Silently skip unrecognized options, it should be up to the …
53e1359 
…transport to decide if they cause an error
@mappum @jbenet
commands: Fixed test
b033e33
@mappum @jbenet
commands: Added Context() to Request
20f86c0
@mappum @jbenet
commands/http: Made client load RPC host from config
48bd73c
@mappum @jbenet
commands: Added Request#SetContext()
289bce6
@mappum @jbenet
commands/http: Made Handler set request contexts
29b96b6
@mappum @jbenet
commands/http: Moved http request parsing into a Parse function
52bc8bd
@mappum @jbenet
commands/http: Parse command args
7531625
@mappum @jbenet
commands/http: Send request arguments in client requests
42633e5
@mappum @jbenet
commands/http: Use request body as command input stream
507192e
@mappum @jbenet
commands: Gave Requests a reference to the command they are being cal…
81f2925 
…led on
@mappum @jbenet
commands: Added a Format function to Command, for creating human-read…
38f8f1c 
…able output based on a Response
@mappum @jbenet
commands: Added plaintext marshalling to Response#Marshal()
b54801c
@mappum @jbenet
commands/http: Explicitly define the MIME types for each encoding
714e13b
@mappum @jbenet
commands/http: Don't try to parse HTTP response into a Response, just…
32a2959 
… read the output
@mappum @jbenet
commands: Fixed tests
6302356
@mappum @jbenet
commands: Added a Type field for defining output struct formats
ef290fa
@mappum @jbenet
commands/http: Made HTTP client unmarshal response values based on th…
c0a9871 
…e Command#Type
@jbenet
fix(cmd/ipfs2, commands) imports
b1bf60b
@mappum @jbenet
commands: Moved argument checking into a Command method, fail early w…
75649f3 
…hen parsing commands
@mappum @jbenet
commands: Renamed Response#Value to Response#Output
69a56de
@mappum @jbenet
commands: Return a reader in a Response#Reader method, instead of mak…
f6c3888 
…ing Response implementing io.Reader
@mappum @jbenet
commands: Cleaned up argument validation
bc6938d
@mappum @jbenet
commands/http: Ensure request URLs start with expected prefix
446acdc
@mappum @jbenet
commands/http: Respond with error if encoding option isn't a string
4552fce
@mappum @jbenet
commands/http: Unexported Handler fields and created constructor
f76048f
@mappum @jbenet
commands: Nicer syntax for Argument definition
958e524
@mappum @jbenet
commands/cli: Better comment for parsePath
068e10c
@mappum @jbenet
commands: Replaced 'Formatter' with 'Marshaller'
0149f65
@mappum @jbenet
commands: Safer type coercion when choosing marshaller
33ad56e
@mappum @jbenet
commands: Allow overriding marshaller for any encoding type
2a1116c
@mappum @jbenet
commands/http: Refactored API to a Client object that takes a string …
5e5d534 
…address
@mappum @jbenet
commands/http: Cleaner URL formation in client
33b0990
@mappum @jbenet
commands/http: Use net/url querystring encoder
e57cd9b
@mappum @jbenet
commands/http: Decomposed Client#Send function
c8ae4b6
@mappum @jbenet
commands/http: Renamed variable for clarity
df6c700
@mappum @jbenet
commands: Fixed panic when trying to marshal without a command set in…
db9c7f7 
… request
@mappum @jbenet
commands/http: Cleaned up argument handling in Parse
1b9b603
@jbenet
Copy link
Member Author

jbenet commented Nov 4, 2014

@maybebtc nvm. i rebased on top of master, so now things will be different.

leeroy jenkins.

jbenet added a commit that referenced this pull request Nov 4, 2014
@jbenet
Merge pull request #262 from jbenet/cmd-ref-part1
b1958be 
Commands Refactor Part 1
@jbenet jbenet merged commit b1958be into master Nov 4, 2014
@jbenet jbenet deleted the cmd-ref-part1 branch November 4, 2014 10:06
@jbenet jbenet removed the status/in-progress In progress label Nov 4, 2014
@btc
Copy link
Contributor

btc commented Nov 4, 2014

I found one instance of casting I wanted to address. Addressed in a branch of miscellaneous changes. Can merge later.

5216bf1
https://github.com/jbenet/go-ipfs/tree/maybebtc-november

@jbenet
Copy link
Member Author

jbenet commented Nov 4, 2014

@maybebtc add it to cmd-ref-part2

@btc
Copy link
Contributor

btc commented Nov 4, 2014

done

976a7c1
d1405e4

@jbenet jbenet mentioned this pull request Nov 4, 2014
Closed
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
@raulk
Merge pull request ipfs#262 from raulk/fix/dialqueue-enqchan
5f67727 
dial queue: fix possible goroutine leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbenet @btc @mappum