Use datastore based pinning #7750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
For easier browsing, the actual implementation used in this PR seems to be: ipfs/go-ipfs-pinner#4 |
aschmahmann
reviewed
Nov 24, 2020
|
|
||
| pinning, err := pin.LoadPinner(rootDS, syncDs, syncInternalDag) | ||
| ctx, cancel := context.WithTimeout(context.TODO(), 2*time.Minute) |
There was a problem hiding this comment.
I grabbed the 2 minutes from the other PR, but ideally rebuilding shouldn't take this long.
gammazero
force-pushed
the
feat/datastore-pinner
branch
2 times, most recently
from
9b2f971
to
9cc21a7
Compare
aschmahmann
force-pushed
the
feat/datastore-pinner
branch
from
9cc21a7
to
bec1a83
Compare
aschmahmann
force-pushed
the
feat/datastore-pinner
branch
from
bec1a83
to
9bc8f6d
Compare
aschmahmann
approved these changes
Dec 8, 2020
This was referenced Feb 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.