fix(core/node): unwrap fx error in node construction #8638
Merged
+51
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schomatis
force-pushed
the
schomatis/fix/core/node/unwrap-fx-error
branch
from
ac9bd46
to
02f7950
Compare
|
@schomatis : there was approval on this PR. Can you get CI to pass and then merge? |
|
There is another of those weird js-ipfs |
schomatis
force-pushed
the
schomatis/fix/core/node/unwrap-fx-error
branch
from
02f7950
to
519863e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the nicest solution but to extract more information from the errors I had to go the reflection way which added too much complexity for not too much more value.
Closes #6651.