Do not disconnect from VPN over cellular if security level is medium

iphoting · Aug 29, 2019 · 5b0c19a · 5b0c19a
1 parent e0d1fd1
commit 5b0c19a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/features/gen_basic.feature b/features/gen_basic.feature
@@ -323,7 +323,7 @@ Feature: Basic Generate Functionality
  And the output should match:
  """
  <key>Action</key>
- \s*<string>Disconnect</string>
+ \s*<string>Ignore</string>
  \s*<key>InterfaceTypeMatch</key>
  \s*<string>Cellular</string>
  """

diff --git a/lib/ovpnmcgen.rb b/lib/ovpnmcgen.rb
@@ -122,14 +122,14 @@ def generate(inputs = {})
  vodCellularOnly = { # Trust Cellular
  'InterfaceTypeMatch' => 'Cellular',
  'Action' => case inputs[:security_level]
- when 'paranoid'
- 'Connect'
- when 'high'
- 'Ignore'
- else # medium
- 'Disconnect'
- end
+ when 'paranoid'
+ 'Connect'
+ else # high, medium
+ 'Ignore'
+ end
  }
+
+ # Default catch-all to prevent circular race.
  vodDefault = { # Default catch-all
  'Action' => 'Ignore'
  }