Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not disconnect from VPN over cellular if security level is medium #33

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

ruimarinho
Copy link
Contributor

I believe this was done in mistake as I don't see a reason for disconnecting over cellular when the security level is medium or higher. At least I would say it's safer if we simply ignore the directive.

@ruimarinho ruimarinho changed the title Do not disconnect from VPN if security level is medium Do not disconnect from VPN over cellular if security level is medium Aug 29, 2019
@ruimarinho
Copy link
Contributor Author

@iphoting have you given a thought to this yet?

@iphoting
Copy link
Owner

iphoting commented Sep 8, 2019

I don't disagree with your rationale. Just thinking over whether this is considered a "breaking change".
I'm inclined to think that this just requires a minor version bump with some behaviour change text within the change log.

What do you think?

@ruimarinho
Copy link
Contributor Author

According to the README, under the medium level description it says Else if the primary network interface becomes Cellular, leave any existing VPN connection up, but do not reconnect on demand. I assume this is what Ignore would do, not Disconnect, right?

@iphoting
Copy link
Owner

iphoting commented Sep 8, 2019

Ok good point, it’ll be a bug fix.
Will need to rebase this branch before merging.

@ruimarinho
Copy link
Contributor Author

Done!

@iphoting iphoting merged commit 574394a into iphoting:develop Sep 9, 2019
@iphoting
Copy link
Owner

iphoting commented Sep 9, 2019

Thanks for catching this!

@ruimarinho ruimarinho deleted the bugfix/cellular-disconnect branch September 9, 2019 09:55
iphoting added a commit that referenced this pull request Sep 10, 2019
v0.7.1

- Bug fix: Do not disconnect from VPN over cellular if security level is
medium (#33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants