From ae7637bce0bb070452b0c707b4ca4349c91458f3 Mon Sep 17 00:00:00 2001 From: Sylvain Corlay Date: Wed, 31 Mar 2021 17:52:26 +0200 Subject: [PATCH] Simplify should_dispatch_immediately --- ipykernel/ipkernel.py | 2 +- ipykernel/kernelbase.py | 8 ++------ 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/ipykernel/ipkernel.py b/ipykernel/ipkernel.py index 2c8493e20..8a6e7c6b6 100644 --- a/ipykernel/ipkernel.py +++ b/ipykernel/ipkernel.py @@ -556,7 +556,7 @@ def do_clear(self): self.shell.reset(False) return dict(status='ok') - def should_dispatch_immediately(self, msg, *args): + def should_dispatch_immediately(self, msg): try: msg_type = msg['header']['msg_type'] if msg_type in self.comm_msg_types: diff --git a/ipykernel/kernelbase.py b/ipykernel/kernelbase.py index 9c261855d..73f7ae23d 100644 --- a/ipykernel/kernelbase.py +++ b/ipykernel/kernelbase.py @@ -399,9 +399,7 @@ def dispatch_queue(self): def _message_counter_default(self): return itertools.count() - def should_dispatch_immediately( - self, msg, idents, dispatch - ): + def should_dispatch_immediately(self, msg): """ This provides a hook for dispatching incoming messages from the frontend immediately, and out of order. @@ -423,9 +421,7 @@ def schedule_dispatch(self, msg, dispatch): new_args = (msg, idents) - if self.should_dispatch_immediately( - msg, idents, dispatch - ): + if self.should_dispatch_immediately(msg): return self.io_loop.add_callback(dispatch, *new_args) idx = next(self._message_counter)